Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:notification): support nzData as context in template #2926

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 19, 2019

close #2755

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2755

What is the new behavior?

Now user can pass an nzData when use template in notification, this nzData would be access in the template with name data.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@wzhudev
Copy link
Member Author

wzhudev commented Feb 19, 2019

I guess the demo should be optimized...

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0734cd1

https://deploy-preview-2926--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #2926 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2926   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files         524      524           
  Lines       11042    11042           
  Branches      782      782           
=======================================
  Hits        10751    10751           
  Misses        190      190           
  Partials      101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0cec2...0734cd1. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 51940f7 into NG-ZORRO:master Feb 20, 2019
@wzhudev wzhudev deleted the notifiction-template branch February 22, 2019 02:29
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notification description cant add css styles, and cant add click function, they are not work
2 participants