Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:all): support disable animations in every components #2975

Merged
merged 5 commits into from
Feb 27, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Feb 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2401, #2922

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

HTML:

<nz-modal nzNoAnimation></nz-modal>
<ul nz-menu nzNoAnimation></nz-menu>
<nz-form-explain nzNoAnimation></nz-form-explain>

Service:

modalService.create({
...,
nzNoAnimation: true
})

Global:

@NgModule({
  imports     : [
   ...,
-   BrowserAnimationsModule
+   NoopAnimationsModule
  ]
})
export class AppModule {
}

@netlify
Copy link

netlify bot commented Feb 27, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 55196c1

https://deploy-preview-2975--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz marked this pull request as ready for review February 27, 2019 05:33
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #2975 into master will decrease coverage by <.01%.
The diff coverage is 93.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2975      +/-   ##
==========================================
- Coverage   97.39%   97.38%   -0.01%     
==========================================
  Files         546      548       +2     
  Lines       11281    11378      +97     
  Branches      809      812       +3     
==========================================
+ Hits        10987    11081      +94     
- Misses        186      187       +1     
- Partials      108      110       +2
Impacted Files Coverage Δ
components/tag/nz-tag.component.ts 100% <ø> (ø) ⬆️
components/drawer/nz-drawer-ref.ts 100% <ø> (ø) ⬆️
components/tree/nz-tree.component.ts 98.34% <100%> (ø) ⬆️
...mponents/select/nz-select-top-control.component.ts 100% <100%> (ø) ⬆️
components/popconfirm/nz-popconfirm.component.ts 100% <100%> (ø) ⬆️
components/menu/nz-submenu.component.ts 98.82% <100%> (+0.02%) ⬆️
components/popover/nz-popover.component.ts 100% <100%> (ø) ⬆️
components/tooltip/nz-tooltip.module.ts 100% <100%> (ø) ⬆️
components/select/nz-select.module.ts 100% <100%> (ø) ⬆️
...omponents/date-picker/abstract-picker.component.ts 100% <100%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e45ea...55196c1. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 0d7736e into NG-ZORRO:master Feb 27, 2019
@hsuanxyz hsuanxyz deleted the feat/no-animation branch April 22, 2019 02:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ZORRO#2975)

* feat(module:all): support disable animations in every components

close NG-ZORRO#2401, close NG-ZORRO#2922

* feat(module:no-animation): use `ANIMATION_MODULE_TYPE` as the second condition

* build: fix build error

* docs(module:animatons): add animations docs

* test(module:drawer): fix test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ZORRO#2975)

* feat(module:all): support disable animations in every components

close NG-ZORRO#2401, close NG-ZORRO#2922

* feat(module:no-animation): use `ANIMATION_MODULE_TYPE` as the second condition

* build: fix build error

* docs(module:animatons): add animations docs

* test(module:drawer): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants