Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:auto-complete,mention,select,tree-select): prevent loss of focus when the options click #2979

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Feb 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2448

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

https://github.com/react-component/select/blob/master/src/Select.tsx#L1356

@netlify
Copy link

netlify bot commented Feb 27, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 920e736

https://deploy-preview-2979--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #2979 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2979   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files         548      548           
  Lines       11378    11378           
  Branches      812      812           
=======================================
  Hits        11081    11081           
  Misses        187      187           
  Partials      110      110
Impacted Files Coverage Δ
.../auto-complete/nz-autocomplete-option.component.ts 97.61% <ø> (ø) ⬆️
components/drawer/nz-drawer-ref.ts 100% <ø> (ø) ⬆️
components/tree/nz-tree-node.component.ts 99.02% <ø> (ø) ⬆️
components/select/nz-option-li.component.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7736e...920e736. Read the comment docs.

@hsuanxyz hsuanxyz changed the title feat(module:auto-complete): prevent loss of focus when the options click feat(module:auto-complete,mention,select,tree-select): prevent loss of focus when the options click Feb 27, 2019
@vthinkxie vthinkxie merged commit fcaa6d1 into NG-ZORRO:master Feb 27, 2019
@hsuanxyz hsuanxyz deleted the feat/auto-complete#2448 branch April 22, 2019 02:41
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…f focus when the options click (NG-ZORRO#2979)

* feat(module:auto-complete,mention,select,tree-select): prevent loss of focus when the options click

close NG-ZORRO#2448

* fix(module:drawer): fix cannot find module error
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…f focus when the options click (NG-ZORRO#2979)

* feat(module:auto-complete,mention,select,tree-select): prevent loss of focus when the options click

close NG-ZORRO#2448

* fix(module:drawer): fix cannot find module error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants