Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:fesm2015): fix fesm2015 build error #3015

Merged
merged 1 commit into from
Mar 4, 2019
Merged

fix(module:fesm2015): fix fesm2015 build error #3015

merged 1 commit into from
Mar 4, 2019

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 007310c

https://deploy-preview-3015--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #3015 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   97.35%   97.36%   +0.01%     
==========================================
  Files         550      549       -1     
  Lines       11454    11438      -16     
  Branches      815      814       -1     
==========================================
- Hits        11151    11137      -14     
+ Misses        190      188       -2     
  Partials      113      113
Impacted Files Coverage Δ
components/core/util/public-api.ts 100% <ø> (ø) ⬆️
components/i18n/date-helper.service.ts 88.37% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ed317...007310c. Read the comment docs.

import fnsFormat from 'date-fns/format';
import fnsGetISOWeek from 'date-fns/get_iso_week';
import fnsParse from 'date-fns/parse';
import { mergeDateConfig, NzDateConfig, NZ_DATE_CONFIG } from './date-config';
import { NzI18nService } from './nz-i18n.service';

export function DATE_HELPER_SERVICE_FACTORY(i18n: NzI18nService, config: NzDateConfig, datePipe: DatePipe): DateHelperService {
export function DATE_HELPER_SERVICE_FACTORY(injector: Injector, config: NzDateConfig, datePipe: DatePipe): DateHelperService {
const i18n = injector.get(NzI18nService);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改用Injector的原因是什么呢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fesm2015 下会报错

@vthinkxie vthinkxie merged commit e5b388a into NG-ZORRO:master Mar 4, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants