-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:fesm2015): fix fesm2015 build error #3015
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 007310c |
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
==========================================
+ Coverage 97.35% 97.36% +0.01%
==========================================
Files 550 549 -1
Lines 11454 11438 -16
Branches 815 814 -1
==========================================
- Hits 11151 11137 -14
+ Misses 190 188 -2
Partials 113 113
Continue to review full report at Codecov.
|
import fnsFormat from 'date-fns/format'; | ||
import fnsGetISOWeek from 'date-fns/get_iso_week'; | ||
import fnsParse from 'date-fns/parse'; | ||
import { mergeDateConfig, NzDateConfig, NZ_DATE_CONFIG } from './date-config'; | ||
import { NzI18nService } from './nz-i18n.service'; | ||
|
||
export function DATE_HELPER_SERVICE_FACTORY(i18n: NzI18nService, config: NzDateConfig, datePipe: DatePipe): DateHelperService { | ||
export function DATE_HELPER_SERVICE_FACTORY(injector: Injector, config: NzDateConfig, datePipe: DatePipe): DateHelperService { | ||
const i18n = injector.get(NzI18nService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改用Injector的原因是什么呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fesm2015 下会报错
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information