Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): fix click checkbox can't trigger selection #3030

Merged
merged 9 commits into from
Mar 6, 2019
Merged

fix(module:transfer): fix click checkbox can't trigger selection #3030

merged 9 commits into from
Mar 6, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Mar 6, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3026

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cipchk and others added 9 commits December 8, 2018 16:41
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: Wilson Zeng <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: Ekko <[email protected]>
Co-authored-by: null <[email protected]>
chore: merge master

Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Wendell <[email protected]>
Co-authored-by: Wilson Zeng <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: GQ <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: simplejason <[email protected]>
Co-authored-by: null <[email protected]>
@netlify
Copy link

netlify bot commented Mar 6, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5dc7152

https://deploy-preview-3030--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #3030 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
- Coverage   97.33%   97.32%   -0.01%     
==========================================
  Files         549      549              
  Lines       11490    11490              
  Branches      815      815              
==========================================
- Hits        11184    11183       -1     
- Misses        196      197       +1     
  Partials      110      110
Impacted Files Coverage Δ
components/transfer/nz-transfer-list.component.ts 98.36% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2636d5f...5dc7152. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit f077294 into NG-ZORRO:master Mar 6, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants