fix(module:cascader): fix columns not dropped #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 5385791 |
Codecov Report
@@ Coverage Diff @@
## master #3037 +/- ##
==========================================
+ Coverage 97.3% 97.32% +0.02%
==========================================
Files 550 552 +2
Lines 11539 11594 +55
Branches 826 826
==========================================
+ Hits 11228 11284 +56
+ Misses 201 200 -1
Partials 110 110
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
wzhudev
force-pushed
the
refactor-cascader
branch
2 times, most recently
from
48c9f96
to
0d863e0
Compare
simplejason
requested review from
simplejason
and removed request for
vthinkxie and
fbchen
simplejason
reviewed
Mar 21, 2019
added 6 commits
March 21, 2019 11:36
close NG-ZORRO#3034 fix: multi fixes fix: fix bugs to pass tests chore: get test specs back fix: rollup fix: try to fix rollup by locking version test: add aborting searching test fix: lint chore: try to adopt prettier chore: remove @Private
wzhudev
force-pushed
the
refactor-cascader
branch
from
8f7b2e6
to
5385791
Compare
simplejason
approved these changes
Mar 21, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* fix(module:cascader): fix columns not dropped fix: multi fixes fix: fix bugs to pass tests chore: get test specs back fix: rollup fix: try to fix rollup by locking version test: add aborting searching test fix: lint chore: try to adopt prettier chore: remove @Private * fix: fix types in utils * fix: remove redefined interfaces * fix: fix cascacder folded when quiting searching mode * fix: set timer to null * fix: fix cannot be reset & column not drop for leaf node close NG-ZORRO#3034
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* fix(module:cascader): fix columns not dropped fix: multi fixes fix: fix bugs to pass tests chore: get test specs back fix: rollup fix: try to fix rollup by locking version test: add aborting searching test fix: lint chore: try to adopt prettier chore: remove @Private * fix: fix types in utils * fix: remove redefined interfaces * fix: fix cascacder folded when quiting searching mode * fix: set timer to null * fix: fix cannot be reset & column not drop for leaf node close NG-ZORRO#3034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3027
refactor(module:cascader): refactor cascader
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
When you click an option in the second column, the third column would be removed. So the bug in that issue gets resolved.
I also refactored the component for less maintenance cost in the future. Not UI directly related logic was moved to
NzCascaderService. Lots of redundant code and logic were removed.Does this PR introduce a breaking change?
Other information