Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:message): support nzTop #3047

Merged
merged 5 commits into from
Mar 20, 2019
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 8, 2019

close #3041

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 8, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 58457ee

https://deploy-preview-3047--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #3047 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
+ Coverage   97.32%   97.32%   +<.01%     
==========================================
  Files         550      550              
  Lines       11510    11525      +15     
  Branches      819      824       +5     
==========================================
+ Hits        11202    11217      +15     
  Misses        199      199              
  Partials      109      109
Impacted Files Coverage Δ
components/notification/nz-notification-config.ts 100% <ø> (ø) ⬆️
components/message/nz-message-config.ts 100% <ø> (ø) ⬆️
...otification/nz-notification-container.component.ts 100% <100%> (ø) ⬆️
...mponents/message/nz-message-container.component.ts 96.87% <100%> (+0.32%) ⬆️
components/select/nz-select.component.ts 98.01% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494e18f...58457ee. Read the comment docs.

components/test.ts Outdated Show resolved Hide resolved
@wzhudev wzhudev requested a review from hsuanxyz March 12, 2019 04:16
@hsuanxyz hsuanxyz merged commit 351135b into NG-ZORRO:master Mar 20, 2019
@wzhudev wzhudev deleted the message-top branch March 20, 2019 08:34
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:message): support nzTop

* fix: types

* fix: add new test case of nzTop & nzBottom

* fix: lint

* docs: add unit

close NG-ZORRO#3041
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:message): support nzTop

* fix: types

* fix: add new test case of nzTop & nzBottom

* fix: lint

* docs: add unit

close NG-ZORRO#3041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] message support set top distance
2 participants