Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): simple confirm should not have cancel button #3115

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3107

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a6ef43a

https://deploy-preview-3115--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3115 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3115   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         550      550           
  Lines       11513    11513           
  Branches      820      820           
=======================================
  Hits        11205    11205           
  Misses        199      199           
  Partials      109      109
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 99.01% <100%> (ø) ⬆️
components/modal/nz-modal.service.ts 96.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a06cf...a6ef43a. Read the comment docs.

@hsuanxyz hsuanxyz merged commit f0a2b51 into NG-ZORRO:master Mar 20, 2019
@hsuanxyz hsuanxyz deleted the fix/modal-confirm branch April 22, 2019 02:39
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants