Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:drawer): create focus trap error when nzVisible default value is true #3203

Merged
merged 1 commit into from
Apr 15, 2019
Merged

fix(module:drawer): create focus trap error when nzVisible default value is true #3203

merged 1 commit into from
Apr 15, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Apr 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3200

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Apr 1, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5b95ebe

https://deploy-preview-3203--ng-zorro-master.netlify.com

wzhudev
wzhudev approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 327ceca into NG-ZORRO:master Apr 15, 2019
@hsuanxyz hsuanxyz deleted the fix/drawer-init-open branch April 22, 2019 02:39
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
@hsuanxyz @andrew-yangy
fix(module:drawer): create focus trap error when nzVisible default …
b6a7d5f 
…value is true (NG-ZORRO#3203)

close NG-ZORRO#3200
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
fix(module:drawer): create focus trap error when nzVisible default …
8555e1a 
…value is true (NG-ZORRO#3203)

close NG-ZORRO#3200
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz
fix(module:drawer): create focus trap error when nzVisible default …
ce37bf5 
…value is true (NG-ZORRO#3203)

close NG-ZORRO#3200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsuanxyz @wzhudev