fix(moment): use replace plugin to replace moment

[LinboLen]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #315 #85 #169 #240

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

[trotyl]

We don't provide sourcemap at all, what is it going to fix?

[coveralls]

Coverage remained the same at 40.774% when pulling d9a1284 on gradii:fix-rollup-sourcemap into 6e4794b on NG-ZORRO:master.

[LinboLen]

error occurs in my project. if there are no correct sourcemap file. rollup can't bundle file

Before

import sourcemaps from 'rollup-plugin-sourcemaps';
import replace from 'rollup-plugin-replace';

function replaceMoment() {
  return {
    name: 'replace-moment-import',
    transform: code =>
            ({
              code: code.replace('import * as moment', 'import moment'),
            })
  }
}
export default {plugins: [replaceMoment(), sourcemaps()]};

can't generate bundle file from esm5/index.js

sourcemap file is incorrectly

After

import sourcemaps from 'rollup-plugin-sourcemaps';
import replace from 'rollup-plugin-replace';

export default { plugins: [replace({ "import * as moment": "import moment" }),sourcemaps()] };

---

---

issue occur with rollup command

node_modules/.bin/rollup -c packages/time-picker/rollup.config.js

rollup.config.js

import resolve from 'rollup-plugin-node-resolve';
import sourcemaps from 'rollup-plugin-sourcemaps';

const globals = {

  '@angular/animations':                  'ng.animations',
  '@angular/core':                        'ng.core',
  '@angular/common':                      'ng.common',
  '@angular/forms':                       'ng.forms',
  '@angular/http':                        'ng.http',
  '@angular/router':                      'ng.router',
  '@angular/platform-browser':            'ng.platformBrowser',
  '@angular/platform-server':             'ng.platformServer',
  '@angular/platform-browser-dynamic':    'ng.platformBrowserDynamic',
  '@angular/platform-browser/animations': 'ng.platformBrowser.animations',
  '@angular/core/testing':                'ng.core.testing',
  '@angular/common/testing':              'ng.common.testing',
  '@angular/http/testing':                'ng.http.testing',

  '@angular/cdk':         'ng.cdk',
  '@angular/cdk/testing': 'ng.cdk.testing',

  'rxjs/BehaviorSubject':               'Rx',
  'rxjs/Observable':                    'Rx',
  'rxjs/Subject':                       'Rx',
  'rxjs/Subscription':                  'Rx',
  'rxjs/Observer':                      'Rx',
  'rxjs/Scheduler':                     'Rx',
  'rxjs/observable/combineLatest':      'Rx.Observable',
  'rxjs/observable/forkJoin':           'Rx.Observable',
  'rxjs/observable/fromEvent':          'Rx.Observable',
  'rxjs/observable/merge':              'Rx.Observable',
  'rxjs/observable/of':                 'Rx.Observable',
  'rxjs/observable/throw':              'Rx.Observable',
  'rxjs/observable/defer':              'Rx.Observable',
  'rxjs/operator/auditTime':            'Rx.Observable.prototype',
  'rxjs/operator/catch':                'Rx.Observable.prototype',
  'rxjs/operator/debounceTime':         'Rx.Observable.prototype',
  'rxjs/operator/do':                   'Rx.Observable.prototype',
  'rxjs/operator/filter':               'Rx.Observable.prototype',
  'rxjs/operator/finally':              'Rx.Observable.prototype',
  'rxjs/operator/first':                'Rx.Observable.prototype',
  'rxjs/operator/let':                  'Rx.Observable.prototype',
  'rxjs/operator/map':                  'Rx.Observable.prototype',
  'rxjs/operator/share':                'Rx.Observable.prototype',
  'rxjs/operator/startWith':            'Rx.Observable.prototype',
  'rxjs/operator/switchMap':            'Rx.Observable.prototype',
  'rxjs/operator/takeUntil':            'Rx.Observable.prototype',
  'rxjs/operator/toPromise':            'Rx.Observable.prototype',
  'rxjs/operator/throttleTime':         'Rx.Observable.prototype',
  'rxjs/operator/distinctUntilChanged': 'Rx.Observable.prototype',

  'rxjs/add/observable/merge':              'Rx.Observable',
  'rxjs/add/observable/fromEvent':          'Rx.Observable',
  'rxjs/add/observable/of':                 'Rx.Observable',
  'rxjs/add/observable/interval':           'Rx.Observable',
  'rxjs/add/operator/startWith':            'Rx.Observable.prototype',
  'rxjs/add/operator/map':                  'Rx.Observable.prototype',
  'rxjs/add/operator/debounceTime':         'Rx.Observable.prototype',
  'rxjs/add/operator/distinctUntilChanged': 'Rx.Observable.prototype',
  'rxjs/add/operator/first':                'Rx.Observable.prototype',
  'rxjs/add/operator/catch':                'Rx.Observable.prototype',
  'rxjs/add/operator/switchMap':            'Rx.Observable.prototype',

  'moment': 'moment'
};

export default {
  input: '../../dist/packages-dist/time-picker/esm5/index.js',
  output: {
    file: '../../dist/packages-dist/time-picker/bundles/time-picker.umd.js',
    format: 'umd',
  },
  exports: 'named',
  name: 'ng-zorro-fork.time-picker',
  plugins: [resolve(), sourcemaps()],
  external: Object.keys(globals),
  globals: globals
};

[trotyl]

The process for generating esm5 index file is: ngc -> rollup -> tsc, as tsc won't consume the input sourcemap generated by rollup, the final sourcemap would be wrong anyway.

Actually the input sourcemap feature for TypeScript has not landed yet: https://github.com/Microsoft/TypeScript/issues/13944.

What's the benefit for having a wrong soucemap over not having it?

[trotyl]

Another question, would rollup consume the input sourcemap from ngc? The input files for rollup are already generated files.

[trotyl]

This PR is fine except title not being helpful.

[coveralls]

Coverage remained the same at 40.791% when pulling fa57403 on gradii:fix-rollup-sourcemap into 525edb8 on NG-ZORRO:master.