Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tree): fix nodes list to render correctly #3326

Merged
merged 3 commits into from
Apr 22, 2019

Conversation

simplejason
Copy link
Member

close #3320

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3320

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

components/tree/nz-tree.component.ts Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Apr 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 9cd8109

https://deploy-preview-3326--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #3326 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3326      +/-   ##
==========================================
+ Coverage   97.44%   97.44%   +<.01%     
==========================================
  Files         606      606              
  Lines       11930    11931       +1     
  Branches      869      869              
==========================================
+ Hits        11625    11626       +1     
  Misses        196      196              
  Partials      109      109
Impacted Files Coverage Δ
components/tree/nz-tree.component.ts 98.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91af03...021b094. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 22, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 021b094

https://deploy-preview-3326--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz merged commit 6d759a8 into NG-ZORRO:master Apr 22, 2019
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
* fix(module: tree): fix nodes list to render correctly

close NG-ZORRO#3320

* fix(module: tree): rollback default keys

* fix(module: tree): use nzNodes only
@simplejason simplejason deleted the fix-tree-bug branch August 13, 2019 02:49
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module: tree): fix nodes list to render correctly

close NG-ZORRO#3320

* fix(module: tree): rollback default keys

* fix(module: tree): use nzNodes only
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module: tree): fix nodes list to render correctly

close NG-ZORRO#3320

* fix(module: tree): rollback default keys

* fix(module: tree): use nzNodes only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

树组件拖放问题: 根节点拖放后,不更新界面
2 participants