Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:radio, tab): Fixed memory leak problem. #3354

Merged
merged 2 commits into from
Apr 25, 2019
Merged

fix(module:radio, tab): Fixed memory leak problem. #3354

merged 2 commits into from
Apr 25, 2019

Conversation

binglingshuang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Prevent memory leaks for radio and tabs components.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

No change with behavior.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

When I used the site of ng.ant.design, I found there are other memory leaks in ng-zorro.

Memory Leak

@netlify
Copy link

netlify bot commented Apr 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 539ad0a

https://deploy-preview-3354--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #3354 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
+ Coverage   97.44%   97.44%   +<.01%     
==========================================
  Files         606      606              
  Lines       11931    11935       +4     
  Branches      869      869              
==========================================
+ Hits        11626    11630       +4     
  Misses        196      196              
  Partials      109      109
Impacted Files Coverage Δ
components/radio/nz-radio.component.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tabs-nav.component.ts 97.7% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e72f70...539ad0a. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 7d18fef into NG-ZORRO:master Apr 25, 2019
@binglingshuang binglingshuang deleted the memory-leak branch April 28, 2019 00:56
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:radio, tab): Fixed memory leak problem.

* fix(module:radio, tab): Fixed memory leak problem. (fix tslint)
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:radio, tab): Fixed memory leak problem.

* fix(module:radio, tab): Fixed memory leak problem. (fix tslint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants