Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix the bug of duplication when keyboard input ch… #3440

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

zhoucs624
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3439

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented May 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit d13ccd8

https://deploy-preview-3440--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #3440 into master will decrease coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3440      +/-   ##
==========================================
- Coverage   96.66%   95.48%   -1.18%     
==========================================
  Files         609      609              
  Lines       13187    13185       -2     
  Branches     1803     1802       -1     
==========================================
- Hits        12747    12590     -157     
- Misses        199      215      +16     
- Partials      241      380     +139
Impacted Files Coverage Δ
...mponents/select/nz-select-top-control.component.ts 100% <ø> (ø) ⬆️
components/core/util/getMentions.ts 50% <0%> (-16.67%) ⬇️
components/core/scroll/nz-scroll.service.ts 66.03% <0%> (-13.21%) ⬇️
components/core/polyfill/request-animation.ts 20% <0%> (-12%) ⬇️
components/slider/nz-slider-step.component.ts 88.88% <0%> (-11.12%) ⬇️
components/i18n/nz-i18n.service.ts 80.95% <0%> (-9.53%) ⬇️
components/core/util/textarea-caret-position.ts 42.1% <0%> (-8.78%) ⬇️
components/breadcrumb/nz-breadcrumb.component.ts 56.52% <0%> (-6.53%) ⬇️
components/slider/nz-slider-marks.component.ts 90.47% <0%> (-4.77%) ⬇️
components/select/nz-option-container.component.ts 95.34% <0%> (-4.66%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f353c...d13ccd8. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 3c82f26 into NG-ZORRO:master Jun 22, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants