Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): display error when in tag and search mode #3442

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented May 12, 2019

PR Checklist

Close #3424

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented May 12, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5ecd846

https://deploy-preview-3442--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #3442 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3442      +/-   ##
=========================================
+ Coverage    95.6%   95.6%   +<.01%     
=========================================
  Files         609     609              
  Lines       13250   13256       +6     
  Branches     1810    1814       +4     
=========================================
+ Hits        12668   12674       +6     
  Misses        197     197              
  Partials      385     385
Impacted Files Coverage Δ
components/select/nz-select.service.ts 86.78% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6342657...5ecd846. Read the comment docs.

@simplejason simplejason merged commit a05f5a5 into NG-ZORRO:master Jun 5, 2019
@wenqi73 wenqi73 deleted the 3424 branch June 5, 2019 13:01
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…RO#3442)

close NG-ZORRO#3424
* fix(module:select): display error when in tag and search mode

* fix: concat cached options and selected values
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…RO#3442)

close NG-ZORRO#3424
* fix(module:select): display error when in tag and search mode

* fix: concat cached options and selected values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: 搜索与标签模式一起使用时会产生错误的显示文本
2 participants