Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-table: add nzIsPageIndexReset option #359

Merged
merged 1 commit into from
Sep 23, 2017

Conversation

AlcheXie
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #348

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@AlcheXie AlcheXie changed the title Feat table nz-table: add nzIsPageIndexReset option Sep 22, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.767% when pulling 299e4a4 on AlcheXie:feat-table into 1220c9d on NG-ZORRO:master.

@vthinkxie vthinkxie self-requested a review September 22, 2017 15:03
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlcheXie , thanks for your pr, please make sure your commit history clean and meet the guidelines here https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Your commit history https://github.com/NG-ZORRO/ng-zorro-antd/pull/359/commits
You can use squash to remove the unnecessary commit history.

@AlcheXie
Copy link
Contributor Author

AlcheXie commented Sep 22, 2017

Please forgive me for my bad habits since I had never opened pr before.
I have arranged my commits, is it all right now?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.763% when pulling 2dba90f on AlcheXie:feat-table into 1a997c2 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.763% when pulling e5a9913 on AlcheXie:feat-table into 1a997c2 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.763% when pulling e5a9913 on AlcheXie:feat-table into 1a997c2 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 60e3da9 into NG-ZORRO:master Sep 23, 2017
@AlcheXie AlcheXie deleted the feat-table branch September 23, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants