-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:tree): unexpected disappear of tree-node #3748
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 069a860 |
Codecov Report
@@ Coverage Diff @@
## master #3748 +/- ##
==========================================
- Coverage 95.4% 95.37% -0.04%
==========================================
Files 711 711
Lines 14593 14608 +15
Branches 1924 1927 +3
==========================================
+ Hits 13923 13932 +9
- Misses 243 248 +5
- Partials 427 428 +1
Continue to review full report at Codecov.
|
My bad, change |
Is there anything wrong with the code? I don't know why netlify crashed. |
@orzyyyy Please rebase to the master branch. |
I have tried, but it doesn't work. |
https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/559920055#L1201 |
@orzyyyy We fixed the @angular/cdk breaking change, Please rebase to the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
close NG-ZORRO#3739 * fix: unexpected disappear of tree-node * test(module:nz-tree): update case * perf: add prop shouldHide to nzTreeNode * chore: rename prop shouldHide to canHide * fix: check match status of upstream and downstream tree node * test(module:nz-tree): update fit to it * chore: remove useless access modifier * test: update cases * test: combine two cases
close NG-ZORRO#3739 * fix: unexpected disappear of tree-node * test(module:nz-tree): update case * perf: add prop shouldHide to nzTreeNode * chore: rename prop shouldHide to canHide * fix: check match status of upstream and downstream tree node * test(module:nz-tree): update fit to it * chore: remove useless access modifier * test: update cases * test: combine two cases
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
To close #3739
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I'm a new of ng and nz, and I'm working on how to complete test case, maybe take lots of time...