Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breadcrumb 自动生成面包屑,将NZ_ROUTE_DATA_BREADCRUMB设置为可配置化 #3775

Closed
CK110 opened this issue Jul 12, 2019 · 4 comments
Assignees
Labels
Component: BreadCrumb 🌈 Feature Request Good First Issue Issues recommended for first-time contributor 👨‍🏭 Some one working on this A community member has started working on this

Comments

@CK110
Copy link
Member

CK110 commented Jul 12, 2019

What problem does this feature solve?

router data里面的信息可能用于设置为title,和面包屑很大概率上是同一个值

What does the proposed API look like?

通过inject token实现可配置

@zorro-bot
Copy link

zorro-bot bot commented Jul 12, 2019

Translation of this issue:

Breadcrumb automatically generates breadcrumbs, setting NZ_ROUTE_DATA_BREADCRUMB to configurable

What problem does this feature solve?

The information in router data may be used to set to title, and the breadcrumbs are of the same probability on a large probability.

What does the proposed API look like?

Configurable through inject token

@wzhudev
Copy link
Member

wzhudev commented Jul 12, 2019

Would fix this after the global config service is online.

@wzhudev wzhudev added Good First Issue Issues recommended for first-time contributor help wanted labels Sep 12, 2019
@wzhudev
Copy link
Member

wzhudev commented Sep 12, 2019

Now global config is in the air, welcome to contribute~

@CK110
Copy link
Member Author

CK110 commented Sep 16, 2019

Now global config is in the air, welcome to contribute~

看了 global config, 它是主要设置的组件属性默认值,但是 NZ_ROUTE_DATA_BREADCRUMB还并 不是属性。我觉得可以改为属性 @Input() nzRouteDataBreadcrumbLabel: string = 'breadcrumb'; 。因为系统中不会有很多地方需要 Breadcrumb吧,没必要还可以全局设置默认值吧?

@wzhudev wzhudev added 👨‍🏭 Some one working on this A community member has started working on this and removed help wanted labels Sep 23, 2019
@wzhudev wzhudev closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: BreadCrumb 🌈 Feature Request Good First Issue Issues recommended for first-time contributor 👨‍🏭 Some one working on this A community member has started working on this
Projects
None yet
Development

No branches or pull requests

2 participants