Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pagination): add space between page size and slash #4039

Merged
merged 1 commit into from
Oct 12, 2019
Merged

fix(module:pagination): add space between page size and slash #4039

merged 1 commit into from
Oct 12, 2019

Conversation

oestrogen
Copy link
Contributor

@oestrogen oestrogen commented Aug 21, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

image

Issue Number: #4038

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2143581

https://deploy-preview-4039--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #4039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4039   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         520      520           
  Lines       10991    10991           
  Branches     1990     1990           
=======================================
  Hits        10132    10132           
  Misses        430      430           
  Partials      429      429

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ab305...2143581. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Sep 20, 2019

@oestrogen Thanks for your pull request! Please edit your commit message. Refer to our contributing guide.

@oestrogen
Copy link
Contributor Author

@wendzhue I have now changed the commit message according to the guide. Thanks for the patience! 😊

@vthinkxie vthinkxie changed the title #4038 Add space between page size and slash fix(module:pagination): add space between page size and slash Oct 11, 2019
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants