Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:i18n): fix i18n interface and Traditional Chinese #4102

Merged
merged 2 commits into from
Sep 6, 2019
Merged

fix(module:i18n): fix i18n interface and Traditional Chinese #4102

merged 2 commits into from
Sep 6, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 3, 2019 •
edited
Loading

close #4080

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@auto-assign auto-assign bot requested a review from cipchk September 3, 2019 03:31
@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5a604fe

https://deploy-preview-4102--ng-zorro-master.netlify.com

hsuanxyz
hsuanxyz reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close #4080 in commit

@wzhudev
Copy link
Member Author

wzhudev commented Sep 3, 2019

close #4080 in commit

My intention is to close that issue after the Russian i18n file gets fixed.

@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4642d84

https://deploy-preview-4102--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz merged commit bb9e89f into NG-ZORRO:master Sep 6, 2019
@wzhudev wzhudev mentioned this pull request Sep 9, 2019
Closed
@wzhudev wzhudev deleted the i18n branch September 20, 2019 01:35
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module:i18n): fix i18n interface and Traditional Chinese (NG-ZORR…
92c0ca0 
…O#4102)

* fix(module:i18n): fix i18n interface and Traditional Chinese

* fix: fix typo

close NG-ZORRO#4080
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz
fix(module:i18n): fix i18n interface and Traditional Chinese (NG-ZORR…
7d0d576 
…O#4102)

* fix(module:i18n): fix i18n interface and Traditional Chinese

* fix: fix typo

close NG-ZORRO#4080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsuanxyz hsuanxyz hsuanxyz approved these changes

@cipchk cipchk Awaiting requested review from cipchk

Assignees

@hsuanxyz hsuanxyz

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NzI18nService setLocale(zh_TW) build error: Property 'global' is missing
2 participants
@wzhudev @hsuanxyz