fix(module:date-picker): optimized interaction by using input box #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsuanxyz
requested changes
Sep 12, 2019
pr-triage
bot
added
PR: reviewed-changes-requested
PR: draft
and removed
PR: draft
PR: reviewed-changes-requested
labels
|
Deploy preview for ng-zorro-master ready! Built with commit e30fee3 |
Codecov Report
@@ Coverage Diff @@
## master #4146 +/- ##
==========================================
+ Coverage 92.27% 92.29% +0.01%
==========================================
Files 517 518 +1
Lines 10961 10960 -1
Branches 1985 1983 -2
==========================================
+ Hits 10114 10115 +1
+ Misses 422 420 -2
Partials 425 425
Continue to review full report at Codecov.
|
wenqi73
changed the title
wenqi73
force-pushed
the
fix-input
branch
2 times, most recently
from
d9a7e05
to
fca2ca0
Compare
hsuanxyz
requested changes
Sep 20, 2019
components/date-picker/lib/popups/date-range-popup.component.ts
Outdated
Show resolved
Hide resolved
| this.value = null; // Clear current value to not sync time by next step | ||
| this.changeValue(value); | ||
| // tslint:disable-next-line: no-any | ||
| this.value = null as any; // Clear current value to not sync time by next step |
There was a problem hiding this comment.
value: CompatibleValue | null 如果可以为 null 最好加上类型。
hsuanxyz
approved these changes
Sep 23, 2019
|
“直接点击遮罩关闭不会保存 input值”这个体验还是有点不好啊。 |
|
@lhysrc 感谢反馈，我们会考虑加上。 |
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
…-ZORRO#4146) * fix(module:date-picker): input value change should trigger panel change * chore: update * fix: test * fix: enter on nzShowTime * chore: delete comment * fix: resultOk can set value from input * fix: wrong generic * fix: resolve review comment
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…-ZORRO#4146) * fix(module:date-picker): input value change should trigger panel change * chore: update * fix: test * fix: enter on nzShowTime * chore: delete comment * fix: resultOk can set value from input * fix: wrong generic * fix: resolve review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4130
What is the new behavior?
Does this PR introduce a breaking change?
Other information
优化 date picker 与 range picker 的 input 交互