Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:typography, tabs): make the destroy$ complete when destroy #4271

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #4271 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4271      +/-   ##
==========================================
+ Coverage   92.24%   92.24%   +<.01%     
==========================================
  Files         520      520              
  Lines       10987    10991       +4     
  Branches     1990     1990              
==========================================
+ Hits        10135    10139       +4     
  Misses        426      426              
  Partials      426      426
Impacted Files Coverage Δ
components/typography/nz-text-copy.component.ts 96.66% <100%> (+0.23%) ⬆️
components/tabs/nz-tabset.component.ts 92% <100%> (+0.13%) ⬆️
components/time-picker/time-holder.ts 96.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ccc62a...874a192. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 874a192

https://deploy-preview-4271--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 51f4713 into NG-ZORRO:master Oct 11, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the perf/destroy branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants