fix(module:pagination): replace full-width character with half-width #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4371 +/- ##
==========================================
- Coverage 92.2% 92.19% -0.01%
==========================================
Files 520 520
Lines 11039 11039
Branches 1997 1997
==========================================
- Hits 10178 10177 -1
Misses 429 429
- Partials 432 433 +1
Continue to review full report at Codecov.
|
|
Deploy preview for ng-zorro-master ready! Built with commit 1e5b5cc |
hsuanxyz
reviewed
Nov 4, 2019
| @@ -26,7 +26,7 @@ | |||
| [value]="nzPageIndex" | |||
| (keydown.enter)="handleKeyDown($event,simplePagerInput,false)" | |||
| size="3"> | |||
| <span class="ant-pagination-slash">／</span> | |||
There was a problem hiding this comment.
Thank you for your PR, but fullwidth is expected.
https://github.com/react-component/pagination/blob/master/src/Pagination.jsx#L429
@afc163 Any suggestions?
There was a problem hiding this comment.
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The character used in pagination is changed from '／' with '/'. The full-width one is only used in some Chinese paragraph.
Does this PR introduce a breaking change?
Other information