It cannot close modal when I change a router

[fuybooo]

I'm submitting a...

[ x] Bug report  
[ x] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

step 1: open https://ng.ant.design/#/components/pagination
step 2: open https://ng.ant.design/#/components/modal
step 3: click button '使用component'
step 4: click browser's back button
step 5: check the page, the modal is still visible

Expected behavior

It likes bug #412

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

ng-zorro-antd version: X.Y.Z

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

[hsuanxyz]

Hi @fuybooo:
This is not a BUG, if you used Modal's service, need to control it in the lifecycle hook. like this:

import { Component, OnDestroy } from '@angular/core';
import { NzModalService } from '../../../index.showcase';

@Component({
  selector: 'app-your-component',
  template: `
    <button nz-button [nzType]="'primary'" (click)="showModalForComponent()">
      <span>使用Component</span>
    </button>
  `
})
export class YourComponent implements OnDestroy {
  _modal: any;

  constructor(private modalService: NzModalService) {
  }

  showModalForComponent() {
    this._modal = this.modalService.open({ ... });
  }

  ngOnDestroy() {
    this._modal.destroy('onCancel')
  }
}

  ngOnDestroy() {
+  this._modal.destroy('onCancel')
  }

NzModalSubject.destroy ( type ) - 用于销毁当前的modal对象 - Modal API

[fuybooo]

Ok, thank you very much!

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.