Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: code-editor): fix wrong initialization with diff mode #4532

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Dec 9, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 9, 2019

This preview will be available after the TravisCI is passed.

@netlify
Copy link

netlify bot commented Dec 9, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 09d0a9c

https://deploy-preview-4532--ng-zorro-master.netlify.com

wzhudev
wzhudev previously approved these changes Dec 9, 2019
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #4532 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4532      +/-   ##
==========================================
+ Coverage   93.23%   93.23%   +<.01%     
==========================================
  Files         519      519              
  Lines       12822    12823       +1     
  Branches     2013     2013              
==========================================
+ Hits        11954    11955       +1     
- Misses        452      453       +1     
+ Partials      416      415       -1
Impacted Files Coverage Δ
components/code-editor/nz-code-editor.component.ts 17.89% <0%> (-0.2%) ⬇️
components/time-picker/time-holder.ts 97.31% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f04b8...b4f4fee. Read the comment docs.

@vthinkxie vthinkxie merged commit 021cf22 into NG-ZORRO:master Jan 6, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the 8.x-master/7ef8c63c branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants