Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backward-compatible with the previous rendering engine #5090

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

hsuanxyz
Copy link
Member

close #5088

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 21, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #5090 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5090      +/-   ##
==========================================
+ Coverage   91.44%   91.47%   +0.02%     
==========================================
  Files         546      546              
  Lines       13729    13734       +5     
  Branches     2128     2128              
==========================================
+ Hits        12555    12563       +8     
+ Misses        708      707       -1     
+ Partials      466      464       -2     
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 90.60% <ø> (ø)
components/date-picker/picker.component.ts 95.00% <ø> (+0.03%) ⬆️
...ponents/modal/modal-confirm-container.component.ts 100.00% <ø> (ø)
components/modal/modal-container.component.ts 100.00% <ø> (ø)
components/modal/modal.module.ts 100.00% <ø> (ø)
components/select/select.component.ts 90.53% <ø> (ø)
components/skeleton/skeleton-element.component.ts 100.00% <ø> (ø)
components/core/config/config.ts 100.00% <0.00%> (ø)
components/date-picker/date-picker.module.ts 100.00% <0.00%> (ø)
components/time-picker/time-picker.module.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc39c3...d539131. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit b61a914 into NG-ZORRO:master Apr 21, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not call NzModalModule on project when disable ivy.
3 participants