Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): support clicking host to open panel #5105

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Apr 22, 2020

Fixes #5073

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #5105 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5105   +/-   ##
=======================================
  Coverage   91.44%   91.45%           
=======================================
  Files         546      546           
  Lines       13738    13740    +2     
  Branches     2128     2128           
=======================================
+ Hits        12563    12566    +3     
  Misses        709      709           
+ Partials      466      465    -1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 96.40% <ø> (ø)
components/date-picker/picker.component.ts 95.03% <100.00%> (+0.03%) ⬆️
components/time-picker/time-picker.component.ts 92.70% <100.00%> (+0.07%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1123281...66334c7. Read the comment docs.

@vthinkxie vthinkxie changed the title chore(module:date-picker): support clicking host to open panel fix(module:date-picker): support clicking host to open panel Apr 23, 2020
@vthinkxie vthinkxie merged commit 7c938b4 into NG-ZORRO:master Apr 23, 2020
@wenqi73 wenqi73 deleted the date-picker-click branch April 23, 2020 02:57
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date-picker,time-picker 点击后缀图标不能触发 focus.
3 participants