fix(module:description): fix description not accept TemplateRef #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
|
Clearly I didn't implement that in previous versions... |
Codecov Report
@@ Coverage Diff @@
## master #5139 +/- ##
=======================================
Coverage 91.46% 91.47%
=======================================
Files 547 547
Lines 13747 13768 +21
Branches 2130 2137 +7
=======================================
+ Hits 12574 12594 +20
+ Misses 708 707 -1
- Partials 465 467 +2
Continue to review full report at Codecov.
|
vthinkxie
requested changes
Apr 26, 2020
| @@ -107,7 +117,9 @@ const defaultColumnMap: { [key in NzBreakpointEnum]: number } = { | |||
| <tr class="ant-descriptions-row"> | |||
| <ng-container *ngFor="let item of row; let isLast = last"> | |||
| <td class="ant-descriptions-item-label" [colSpan]="item.span"> | |||
| {{ item.title }} | |||
| <ng-container *nzStringTemplateOutlet="item.title"> | |||
There was a problem hiding this comment.
the type definition of nzTitle also need to update
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
…ORRO#5139) * fix(module:description): fix description not accept TemplateRef close NG-ZORRO#5127 * fix: fix nzTitle type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5127
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information