Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): global config cannot work with service mode #5228

Merged
merged 1 commit into from
May 11, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented May 8, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5223

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 8, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #5228 into master will decrease coverage by 0.01%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5228      +/-   ##
==========================================
- Coverage   91.34%   91.32%   -0.02%     
==========================================
  Files         548      551       +3     
  Lines       13890    13908      +18     
  Branches     2094     2099       +5     
==========================================
+ Hits        12688    12702      +14     
- Misses        710      713       +3     
- Partials      492      493       +1     
Impacted Files Coverage Δ
components/modal/modal-types.ts 100.00% <ø> (ø)
components/modal/modal-container.ts 87.43% <90.47%> (+0.15%) ⬆️
components/badge/badge.component.ts 96.66% <100.00%> (ø)
components/modal/modal-config.ts 100.00% <100.00%> (ø)
...ponents/modal/modal-confirm-container.component.ts 100.00% <100.00%> (ø)
components/modal/modal-container.component.ts 100.00% <100.00%> (ø)
components/modal/modal-ref.ts 97.80% <100.00%> (-1.10%) ⬇️
components/modal/modal.component.ts 96.70% <100.00%> (-0.18%) ⬇️
components/modal/modal.service.ts 91.75% <100.00%> (+1.53%) ⬆️
components/modal/utils.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb618e...7b14e46. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/modal-config-service branch 2 times, most recently from 071d389 to 2bcc7db Compare May 11, 2020 08:36
vthinkxie
vthinkxie previously approved these changes May 11, 2020
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 95aab9a into NG-ZORRO:master May 11, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants