-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:modal): global config cannot work with service mode #5228
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5228 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.02%
==========================================
Files 548 551 +3
Lines 13890 13908 +18
Branches 2094 2099 +5
==========================================
+ Hits 12688 12702 +14
- Misses 710 713 +3
- Partials 492 493 +1
Continue to review full report at Codecov.
|
071d389
to
2bcc7db
Compare
2bcc7db
to
f91520a
Compare
f91520a
to
7b14e46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #5223
What is the new behavior?
Does this PR introduce a breaking change?
Other information