Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): nzAutofocus doesn't work correctly #5313

Merged
merged 1 commit into from
May 25, 2020

Conversation

rorry121
Copy link
Contributor

@rorry121 rorry121 commented May 20, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5319

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 20, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #5313 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5313      +/-   ##
==========================================
- Coverage   91.35%   91.35%   -0.01%     
==========================================
  Files         551      551              
  Lines       13908    13909       +1     
  Branches     2099     2099              
==========================================
  Hits        12706    12706              
  Misses        712      712              
- Partials      490      491       +1     
Impacted Files Coverage Δ
...ponents/modal/modal-confirm-container.component.ts 100.00% <ø> (ø)
components/modal/modal-footer.component.ts 100.00% <ø> (ø)
components/modal/utils.ts 100.00% <ø> (ø)
components/modal/modal.component.ts 96.73% <100.00%> (+0.03%) ⬆️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13142c...4f52259. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants