-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:input): support reactive form disabled #5316
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5316 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 551 551
Lines 13908 13914 +6
Branches 2099 2101 +2
=======================================
+ Hits 12706 12712 +6
Misses 712 712
Partials 490 490
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackblitz.com/edit/angular-fumfvw?file=src/app/app.component.ts
any reason to change the code? any related issues?
when use form.get('xxx').disable(); it's not work |
I think #5307 should be fixed with update the disabled$ inside input directive, the bug is not caused by the attribute of nz-input, but the class of nz-input-group. |
the @input disabled is not changed, you can see the class does not has 'ant-input-disabled',only native disabled work |
there are still some fixes needed, I have submitted it here #5428 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information