Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): support reactive form disabled #5316

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

nuonuoge
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 21, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #5316 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5316   +/-   ##
=======================================
  Coverage   91.35%   91.36%           
=======================================
  Files         551      551           
  Lines       13908    13914    +6     
  Branches     2099     2101    +2     
=======================================
+ Hits        12706    12712    +6     
  Misses        712      712           
  Partials      490      490           
Impacted Files Coverage Δ
components/input/input.directive.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13142c...e7e41f8. Read the comment docs.

@nuonuoge
Copy link
Contributor Author

#5307

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackblitz.com/edit/angular-fumfvw?file=src/app/app.component.ts
any reason to change the code? any related issues?

@nuonuoge
Copy link
Contributor Author

any reason to change the code? any related issues?
https://stackblitz.com/edit/angular-aveg5n-m7xjmv?file=src/app/app.component.ts

when use form.get('xxx').disable(); it's not work

@vthinkxie
Copy link
Member

I think #5307 should be fixed with update the disabled$ inside input directive, the bug is not caused by the attribute of nz-input, but the class of nz-input-group.

@nuonuoge
Copy link
Contributor Author

nuonuoge commented Jun 12, 2020

https://stackblitz.com/edit/angular-fumfvw?file=src/app/app.component.ts

the @input disabled is not changed, you can see the class does not has 'ant-input-disabled',only native disabled work
image

image
image

@vthinkxie vthinkxie merged commit 8270009 into NG-ZORRO:master Jun 16, 2020
@vthinkxie
Copy link
Member

https://stackblitz.com/edit/angular-fumfvw?file=src/app/app.component.ts

the @input disabled is not changed, you can see the class does not has 'ant-input-disabled',only native disabled work
image

image
image

there are still some fixes needed, I have submitted it here #5428
thanks for your PR anyway

@nuonuoge nuonuoge deleted the fixinput branch July 20, 2020 09:22
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants