Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): some cases there is no changes detected #5332

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label May 25, 2020
@zorro-bot
Copy link

zorro-bot bot commented May 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #5332 into master will increase coverage by 0.12%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5332      +/-   ##
==========================================
+ Coverage   91.10%   91.22%   +0.12%     
==========================================
  Files         453      453              
  Lines       13891    13895       +4     
  Branches     2126     2131       +5     
==========================================
+ Hits        12655    12676      +21     
+ Misses        737      722      -15     
+ Partials      499      497       -2     
Impacted Files Coverage Δ
...ponents/modal/modal-confirm-container.component.ts 100.00% <ø> (ø)
components/modal/modal-container.component.ts 100.00% <ø> (ø)
components/modal/modal-container.ts 94.02% <90.32%> (+6.59%) ⬆️
components/modal/modal-ref.ts 97.82% <100.00%> (+0.02%) ⬆️
components/modal/modal.component.ts 96.80% <100.00%> (+0.06%) ⬆️
components/core/config/config.ts 100.00% <0.00%> (ø)
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26469c8...acc654a. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/modal-no-detect branch 3 times, most recently from 384f002 to e4c977b Compare May 26, 2020 07:00
@hsuanxyz hsuanxyz marked this pull request as ready for review May 26, 2020 08:41
@vthinkxie vthinkxie merged commit ade6198 into NG-ZORRO:master Jun 16, 2020
@hsuanxyz hsuanxyz deleted the fix/modal-no-detect branch June 16, 2020 09:57
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…5332)

* fix(module:modal): some cases there is no changes detected

close NG-ZORRO#5328, close NG-ZORRO#5287, close NG-ZORRO#5259

* docs(module:modal): update the API docs

close NG-ZORRO#3743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants