Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:dropdown): fix dropdown disabled button #5429

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

vthinkxie
Copy link
Member

close #5258

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 16, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #5429 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5429   +/-   ##
=======================================
  Coverage   91.20%   91.21%           
=======================================
  Files         551      551           
  Lines       13980    13995   +15     
  Branches     2118     2121    +3     
=======================================
+ Hits        12751    12765   +14     
  Misses        733      733           
- Partials      496      497    +1     
Impacted Files Coverage Δ
components/dropdown/dropdown.directive.ts 88.77% <100.00%> (+0.60%) ⬆️
components/input/input.directive.ts 96.15% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8270009...ce77281. Read the comment docs.

@vthinkxie vthinkxie merged commit 797c65d into NG-ZORRO:master Jun 16, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled on an NZ button with a dropdown doesn't work.
1 participant