Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:drawer): don't prevent events when nzMask is false #5438

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

hsuanxyz
Copy link
Member

close #5350

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5350

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 16, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #5438 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5438      +/-   ##
==========================================
- Coverage   91.34%   91.20%   -0.14%     
==========================================
  Files         551      453      -98     
  Lines       13950    13877      -73     
  Branches     2111     2129      +18     
==========================================
- Hits        12742    12656      -86     
- Misses        717      722       +5     
- Partials      491      499       +8     
Impacted Files Coverage Δ
components/drawer/drawer.component.ts 97.82% <ø> (ø)
components/table/src/cell/th-measure.directive.ts 61.11% <0.00%> (-26.39%) ⬇️
components/radio/radio.service.ts 84.61% <0.00%> (-15.39%) ⬇️
...omponents/table/src/cell/th-selection.component.ts 56.00% <0.00%> (-9.00%) ⬇️
components/table/src/table-data.service.ts 75.38% <0.00%> (-5.87%) ⬇️
components/input/input.directive.ts 96.15% <0.00%> (-3.85%) ⬇️
components/radio/radio.component.ts 93.93% <0.00%> (-3.08%) ⬇️
components/radio/radio-group.component.ts 97.43% <0.00%> (-2.57%) ⬇️
components/select/select.component.ts 87.79% <0.00%> (-2.38%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.40%) ⬇️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c36d6...5854622. Read the comment docs.

@hsuanxyz hsuanxyz changed the title fix(module:drawer): don't prevent events when is false fix(module:drawer): don't prevent events when nzMask is false Jun 16, 2020
@wenqi73 wenqi73 changed the title fix(module:drawer): don't prevent events when nzMask is false fix(module:drawer): don't prevent events when nzMask is false Jun 16, 2020
@wenqi73 wenqi73 merged commit abe9e53 into NG-ZORRO:master Jun 16, 2020
@hsuanxyz hsuanxyz deleted the fix/drawer-no-mask branch June 16, 2020 14:08
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[drawer] mask prevents user interaction when nzMask is set to false
2 participants