Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:upload): add nzPreviewIsImage property #5525

Merged
merged 1 commit into from
Jul 9, 2020
Merged

feat(module:upload): add nzPreviewIsImage property #5525

merged 1 commit into from
Jul 9, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 7, 2020

nzPreviewIsImage 可以更好的自定义预览文件URL是否有效的图像格式,特别是一些CDN它们本身没有一个很明确的图像资源标识,比如:

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- close #5520
- close #4990

`nzPreviewIsImage` 可以更好的自定义预览文件URL是否有效的图像格式,特别是一些CDN它们本身没有一个很明确的图像资源标识,比如:

- https://a.com/1.jpg 一种标准图像路径
- https://a.com/key?w=800&force_format=jpg 也算是一个有效的图像路径
@zorro-bot
Copy link

zorro-bot bot commented Jul 7, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #5525 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5525   +/-   ##
=======================================
  Coverage   91.15%   91.16%           
=======================================
  Files         453      453           
  Lines       13880    13903   +23     
  Branches     2206     2211    +5     
=======================================
+ Hits        12653    12674   +21     
- Misses        727      728    +1     
- Partials      500      501    +1     
Impacted Files Coverage Δ
components/upload/upload-list.component.ts 96.12% <100.00%> (+0.03%) ⬆️
components/upload/upload.component.ts 98.46% <100.00%> (+0.01%) ⬆️
components/core/services/scroll.ts 68.75% <0.00%> (-1.84%) ⬇️
components/tooltip/base.ts 92.72% <0.00%> (-0.35%) ⬇️
components/tooltip/tooltip.ts 100.00% <0.00%> (ø)
components/affix/affix.module.ts 100.00% <0.00%> (ø)
components/anchor/anchor.module.ts 100.00% <0.00%> (ø)
components/popconfirm/popconfirm.ts 100.00% <0.00%> (ø)
components/back-top/back-top.module.ts 100.00% <0.00%> (ø)
components/timeline/timeline.service.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074a3da...d4d7a4a. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit e55a586 into NG-ZORRO:master Jul 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
- close NG-ZORRO#5520
- close NG-ZORRO#4990

`nzPreviewIsImage` 可以更好的自定义预览文件URL是否有效的图像格式,特别是一些CDN它们本身没有一个很明确的图像资源标识,比如:

- https://a.com/1.jpg 一种标准图像路径
- https://a.com/key?w=800&force_format=jpg 也算是一个有效的图像路径
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-upload can't read cloudimage convert url, this url work with html img tag
2 participants