Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:code-editor): init event never emit when using static loading #5677

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #5677 into master will decrease coverage by 0.21%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
- Coverage   90.31%   90.09%   -0.22%     
==========================================
  Files         455      455              
  Lines       13788    13798      +10     
  Branches     2258     2183      -75     
==========================================
- Hits        12452    12431      -21     
- Misses        819      843      +24     
- Partials      517      524       +7     
Impacted Files Coverage Δ
components/code-editor/code-editor.service.ts 19.17% <0.00%> (ø)
components/code-editor/typings.ts 71.42% <100.00%> (ø)
components/tabs/tab-link.directive.ts 37.50% <0.00%> (-62.50%) ⬇️
components/tabs/tabset.component.ts 86.54% <0.00%> (-9.86%) ⬇️
components/tabs/tabs-ink-bar.directive.ts 83.87% <0.00%> (-3.23%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (-2.48%) ⬇️
components/breadcrumb/breadcrumb.component.ts 97.87% <0.00%> (-2.13%) ⬇️
components/tabs/tabs.module.ts 100.00% <0.00%> (ø)
components/tabs/tab.component.ts 92.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5899ad...0d06d61. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the fix/code-editor-static-loading branch from a85173e to 0d06d61 Compare August 14, 2020 05:00
providedIn: 'root',
factory: NZ_CODE_EDITOR_CONFIG_FACTORY
});
export const NZ_CODE_EDITOR_CONFIG = new InjectionToken<NzCodeEditorConfig>('nz-code-editor-config');
Copy link
Member Author

@hsuanxyz hsuanxyz Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提供默认之后总是会报 warning

@vthinkxie vthinkxie merged commit b946742 into NG-ZORRO:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants