Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tag): support icon in tag #5801

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

vthinkxie
Copy link
Member

BREAK CHANGES: '(nzAfterClose)' Output is going to be removed in 9.0.0. Please use '(nzOnClose)' instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #5801 into master will decrease coverage by 0.00%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5801      +/-   ##
==========================================
- Coverage   90.27%   90.27%   -0.01%     
==========================================
  Files         454      456       +2     
  Lines       13789    13747      -42     
  Branches     2171     2164       -7     
==========================================
- Hits        12448    12410      -38     
  Misses        821      821              
+ Partials      520      516       -4     
Impacted Files Coverage Δ
components/badge/badge.module.ts 100.00% <ø> (ø)
components/core/util/check.ts 100.00% <ø> (+16.27%) ⬆️
components/icon/icon.directive.ts 95.16% <ø> (ø)
components/badge/ribbon.component.ts 37.50% <37.50%> (ø)
components/badge/badge-sup.component.ts 100.00% <100.00%> (ø)
components/badge/badge.component.ts 95.00% <100.00%> (-1.37%) ⬇️
components/tag/tag.component.ts 100.00% <100.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01b80a...1cef1e4. Read the comment docs.

close NG-ZORRO#5628 close NG-ZORRO#4581
BREAK CHANGES: '(nzAfterClose)' Output is going to be removed in 9.0.0. Please use '(nzOnClose)' instead.
@github-actions
Copy link

github-actions bot commented Sep 18, 2020

😭 Deploy PR Preview b909354 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant