Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): add range pickers of week, month, year #5832

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 26, 2020

Close #5742

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Sep 26, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #5832 into master will decrease coverage by 0.20%.
The diff coverage is 84.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5832      +/-   ##
==========================================
- Coverage   90.23%   90.03%   -0.21%     
==========================================
  Files         463      463              
  Lines       13900    13922      +22     
  Branches     2186     2202      +16     
==========================================
- Hits        12542    12534       -8     
- Misses        834      854      +20     
- Partials      524      534      +10     
Impacted Files Coverage Δ
components/date-picker/month-picker.component.ts 33.33% <ø> (-66.67%) ⬇️
components/date-picker/range-picker.component.ts 100.00% <ø> (ø)
components/date-picker/week-picker.component.ts 33.33% <ø> (-66.67%) ⬇️
components/date-picker/year-picker.component.ts 33.33% <ø> (-66.67%) ⬇️
components/core/time/candy-date.ts 85.13% <73.07%> (-7.03%) ⬇️
components/date-picker/lib/year-table.component.ts 88.13% <75.00%> (-6.99%) ⬇️
...omponents/date-picker/lib/month-table.component.ts 86.27% <76.66%> (-7.85%) ⬇️
components/date-picker/date-picker.component.ts 92.36% <81.81%> (-2.46%) ⬇️
components/date-picker/lib/abstract-table.ts 89.58% <92.30%> (+2.08%) ⬆️
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf847cf...20a32b7. Read the comment docs.

@wenqi73 wenqi73 force-pushed the feat/month-year-range branch 6 times, most recently from 90d1a84 to 7437d74 Compare September 27, 2020 05:27
@wenqi73 wenqi73 changed the title feat(module:date-picker): add week month year range feat(module:date-picker): add range pickers of week, month, year Sep 27, 2020
@hsuanxyz hsuanxyz merged commit 0725d88 into NG-ZORRO:master Sep 27, 2020
@github-actions
Copy link

github-actions bot commented Sep 27, 2020

😭 Deploy PR Preview 0725d88 failed. Build logs

🤖 By surge-preview

@wenqi73 wenqi73 deleted the feat/month-year-range branch September 27, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-range-picker没有按照年份和月份选择的功能
2 participants