Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker,time-picker): open the panel wrongly in IE11 #5841

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 29, 2020

Fixes #5562

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Sep 29, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #5841 into master will decrease coverage by 0.02%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5841      +/-   ##
==========================================
- Coverage   90.02%   90.00%   -0.03%     
==========================================
  Files         463      463              
  Lines       13920    13925       +5     
  Branches     2201     2202       +1     
==========================================
+ Hits        12532    12533       +1     
- Misses        854      859       +5     
+ Partials      534      533       -1     
Impacted Files Coverage Δ
components/time-picker/time-picker.component.ts 87.20% <60.00%> (+0.20%) ⬆️
components/date-picker/picker.component.ts 91.66% <88.88%> (-0.60%) ⬇️
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts 91.71% <100.00%> (+0.04%) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/code-editor/code-editor.component.ts 13.00% <0.00%> (-0.14%) ⬇️
components/breadcrumb/breadcrumb.component.ts 97.87% <0.00%> (ø)
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea0aae...111517f. Read the comment docs.

@wenqi73 wenqi73 requested a review from hsuanxyz October 9, 2020 03:57
@hsuanxyz hsuanxyz merged commit 89aaa79 into NG-ZORRO:master Oct 9, 2020
@wenqi73 wenqi73 deleted the fix/ie11-dp branch October 9, 2020 05:21
@github-actions
Copy link

github-actions bot commented Oct 9, 2020

😭 Deploy PR Preview 89aaa79 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11DatePicker 加载后就是打开状态
2 participants