Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:breadcrumb): fix breadcrumbs not returned #5863

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 4, 2020

close #4751

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #5863 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5863   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         463      463           
  Lines       13920    13920           
  Branches     2201     2201           
=======================================
  Hits        12531    12531           
  Misses        854      854           
  Partials      535      535           
Impacted Files Coverage Δ
components/breadcrumb/breadcrumb.component.ts 97.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804487c...ae298d0. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 1e3fea2 into NG-ZORRO:master Oct 9, 2020
@github-actions
Copy link

github-actions bot commented Oct 9, 2020

😭 Deploy PR Preview 1e3fea2 failed. Build logs

🤖 By surge-preview

@wzhudev wzhudev deleted the fix/breadcrumb-generate branch October 15, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<nz-breadcrumb nzAutoGenerate> not work when has multiple <router-outlet>s
2 participants