Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): input search not work in IE11 #5953

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 20, 2020

close #5645
close #4296

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 20, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #5953 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5953      +/-   ##
==========================================
+ Coverage   89.99%   90.01%   +0.01%     
==========================================
  Files         463      463              
  Lines       13949    13949              
  Branches     2203     2203              
==========================================
+ Hits        12554    12556       +2     
+ Misses        858      857       -1     
+ Partials      537      536       -1     
Impacted Files Coverage Δ
components/select/select-top-control.component.ts 88.63% <ø> (ø)
components/select/select-search.component.ts 86.95% <100.00%> (ø)
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5530e...b412ad7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants