Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:form): support a fallback locale for validation tips #5967

Merged
merged 1 commit into from
Oct 25, 2020
Merged

feat(module:form): support a fallback locale for validation tips #5967

merged 1 commit into from
Oct 25, 2020

Conversation

danranVm
Copy link
Member

close #5917

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #5967 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   90.01%   89.99%   -0.02%     
==========================================
  Files         465      465              
  Lines       14032    14034       +2     
  Branches     2307     2309       +2     
==========================================
- Hits        12631    12630       -1     
- Misses        855      856       +1     
- Partials      546      548       +2     
Impacted Files Coverage Δ
components/form/form-control.component.ts 92.37% <33.33%> (-1.60%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643bd03...d50146d. Read the comment docs.

@hsuanxyz hsuanxyz merged commit c01e20b into NG-ZORRO:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a fallback locale for validation tips
2 participants