Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): disabled allows to open panel #6008

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Nov 4, 2020

close #6005
close #6007

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 4, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #6008 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6008      +/-   ##
==========================================
+ Coverage   89.95%   89.97%   +0.01%     
==========================================
  Files         465      465              
  Lines       14044    14042       -2     
  Branches     2307     2306       -1     
==========================================
+ Hits        12633    12634       +1     
+ Misses        863      862       -1     
+ Partials      548      546       -2     
Impacted Files Coverage Δ
components/select/select-top-control.component.ts 89.28% <ø> (+0.39%) ⬆️
components/select/select.component.ts 87.70% <100.00%> (+0.16%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f0744...040f771. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple select cursor position nz-select disable allows editing
2 participants