Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:typography): ellipsis does not work with copy action #6058

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

hsuanxyz
Copy link
Member

close #6057

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6057

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 16, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #6058 (03adfc5) into master (84f520d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6058      +/-   ##
==========================================
- Coverage   89.89%   89.88%   -0.02%     
==========================================
  Files         465      465              
  Lines       14055    14057       +2     
  Branches     2310     2311       +1     
==========================================
  Hits        12635    12635              
- Misses        873      876       +3     
+ Partials      547      546       -1     
Impacted Files Coverage Δ
components/typography/typography.component.ts 97.82% <100.00%> (+0.03%) ⬆️
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f520d...03adfc5. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 858fff9 into NG-ZORRO:master Nov 16, 2020
@hsuanxyz hsuanxyz deleted the fix/typography-ellipsis branch November 16, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typography] ellipsis can not work with copyable
1 participant