Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:upload): fix prevent trigger submit when click list button #6096

Merged
merged 1 commit into from
Nov 30, 2020
Merged

fix(module:upload): fix prevent trigger submit when click list button #6096

merged 1 commit into from
Nov 30, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #6096 (7255f0b) into master (c661195) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6096      +/-   ##
==========================================
+ Coverage   89.84%   89.86%   +0.02%     
==========================================
  Files         465      465              
  Lines       14095    14095              
  Branches     2236     2236              
==========================================
+ Hits        12663    12667       +4     
+ Misses        881      877       -4     
  Partials      551      551              
Impacted Files Coverage Δ
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c661195...7255f0b. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 123982f into NG-ZORRO:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect button type for download file in nz-upload
2 participants