Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:steps): steps support circular progress bar #6132

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

yangjunhan
Copy link
Contributor

close #5684

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5684

What is the new behavior?

Support circular progress bar for basic nz-steps.
image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 1, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #6132 (83be548) into master (91e5d49) will decrease coverage by 0.18%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6132      +/-   ##
==========================================
- Coverage   89.89%   89.70%   -0.19%     
==========================================
  Files         479      484       +5     
  Lines       15510    15665     +155     
  Branches     2526     2553      +27     
==========================================
+ Hits        13942    14053     +111     
- Misses        943      974      +31     
- Partials      625      638      +13     
Impacted Files Coverage Δ
components/steps/steps.module.ts 100.00% <ø> (ø)
components/steps/steps.component.ts 91.13% <66.66%> (-5.79%) ⬇️
components/steps/step.component.ts 95.91% <80.00%> (-1.81%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/config/config.ts 100.00% <0.00%> (ø)
components/image/image-preview.component.ts 90.13% <0.00%> (ø)
components/core/services/image-preload.ts 30.55% <0.00%> (ø)
components/experimental/image/image.component.ts 72.97% <0.00%> (ø)
components/experimental/image/image-loader.ts 100.00% <0.00%> (ø)
components/experimental/image/utils.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e5d49...83be548. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, some ci was failed, plz take a look
thanks

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 466a093 into NG-ZORRO:master Jun 11, 2021
@yangjunhan yangjunhan deleted the steps-progress branch June 15, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new feature] steps progress
3 participants