Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): keyboard events in extra areas trigger navigation #6173

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

hsuanxyz
Copy link
Member

close #6139

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6139

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 10, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #6173 (e5a075d) into master (083ed4d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6173      +/-   ##
==========================================
+ Coverage   89.85%   89.87%   +0.01%     
==========================================
  Files         468      468              
  Lines       14255    14256       +1     
  Branches     2242     2242              
==========================================
+ Hits        12809    12812       +3     
+ Misses        891      890       -1     
+ Partials      555      554       -1     
Impacted Files Coverage Δ
components/tabs/tab-nav-bar.component.ts 83.09% <100.00%> (+0.76%) ⬆️
components/alert/alert.component.ts 94.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083ed4d...e5a075d. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 375366f into NG-ZORRO:master Dec 10, 2020
@hsuanxyz hsuanxyz deleted the fix/tabs-keybord-events branch December 10, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-tabset Selected Tab is changed when hitting space or enter key in an input field
1 participant