Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:button): fix nzOkDanger confirm btn and demo #6214

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

yangjunhan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 16, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #6214 (e5d1104) into master (06108ca) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6214   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         477      477           
  Lines       15182    15167   -15     
  Branches     2295     2291    -4     
=======================================
- Hits        13638    13625   -13     
+ Misses        949      946    -3     
- Partials      595      596    +1     
Impacted Files Coverage Δ
...ponents/modal/modal-confirm-container.component.ts 100.00% <ø> (ø)
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tabset.component.ts 83.78% <0.00%> (-0.84%) ⬇️
components/tabs/tab.component.ts 92.59% <0.00%> (-0.27%) ⬇️
components/tabs/tab-link.directive.ts 50.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06108ca...e5d1104. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit ebe2869 into NG-ZORRO:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants