Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table and pagination): support custom the page size changer select values(#608) #626

Merged
merged 2 commits into from
Nov 28, 2017

Conversation

hllinc
Copy link
Contributor

@hllinc hllinc commented Nov 28, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

support custom the page size changer select values.
Issue Number: #608

What is the new behavior?

support custom the page size changer select values

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 41.752% when pulling 9113fec on hllinc:master into 8f7d38b on NG-ZORRO:master.

@hllinc
Copy link
Contributor Author

hllinc commented Nov 28, 2017

@coveralls check failed? why?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 41.752% when pulling 734abe7 on hllinc:master into 8f7d38b on NG-ZORRO:master.

@vthinkxie
Copy link
Member

@hllinc it is ok, don't worry about it.

@hllinc
Copy link
Contributor Author

hllinc commented Nov 28, 2017

@vthinkxie when will it work so that I can use in my project?

@vthinkxie
Copy link
Member

vthinkxie commented Nov 28, 2017

Sat is the latest time if everything is ok

@vthinkxie vthinkxie merged commit 034bd71 into NG-ZORRO:master Nov 28, 2017
@hllinc
Copy link
Contributor Author

hllinc commented Nov 30, 2017

@vthinkxie only the 0.6.2 version support this feature? Does this version work well only in angular 5.x? my project use the angular's version is 4.2.4, oh no.

@vthinkxie
Copy link
Member

@hllinc please upgrade to angular 5.0, there is almost no break change.

@hllinc
Copy link
Contributor Author

hllinc commented Dec 11, 2017

@vthinkxie Can I have your qq or email?

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…er select values(NG-ZORRO#608) (NG-ZORRO#626)

* feat(module:table and pagination): support custom the page size changer select values(NG-ZORRO#608)

* style(module:table and pagination): modify the code annotation.
close NG-ZORRO#608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants