Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): memory leak #6325

Merged
merged 1 commit into from
Jan 13, 2021
Merged

fix(module:table): memory leak #6325

merged 1 commit into from
Jan 13, 2021

Conversation

olivewind
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

image

Issue Number: N/A

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 8, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #6325 (6a28126) into master (8ac8723) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6325      +/-   ##
==========================================
- Coverage   89.93%   89.90%   -0.03%     
==========================================
  Files         478      478              
  Lines       15250    15250              
  Branches     2318     2318              
==========================================
- Hits        13715    13711       -4     
- Misses        923      925       +2     
- Partials      612      614       +2     
Impacted Files Coverage Δ
components/table/src/table/tr.directive.ts 82.22% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.39% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac8723...6a28126. Read the comment docs.

@vthinkxie vthinkxie merged commit 7f267b6 into NG-ZORRO:master Jan 13, 2021
@jeffrey-liu-025
Copy link

存在大量的严重的内存泄漏问题,竟然不重视解决,简直骇人听闻

@olivewind olivewind deleted the fix/table-memory-leak branch June 7, 2021 02:38
@suzhengda
Copy link

9.3.0 一堆内存泄露

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants