Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:space): add nzSplit support #6487

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Mar 5, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #6487 (319b0dc) into master (85ea273) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6487      +/-   ##
==========================================
+ Coverage   89.82%   89.86%   +0.03%     
==========================================
  Files         478      479       +1     
  Lines       15314    15323       +9     
  Branches     2475     2333     -142     
==========================================
+ Hits        13756    13770      +14     
+ Misses        940      935       -5     
  Partials      618      618              
Impacted Files Coverage Δ
components/pagination/pagination-item.component.ts 100.00% <ø> (ø)
components/space/space.module.ts 100.00% <ø> (ø)
components/space/space-item.component.ts 100.00% <100.00%> (ø)
components/space/space-item.directive.ts 100.00% <100.00%> (ø)
components/space/space.component.ts 100.00% <100.00%> (ø)
components/tooltip/base.ts 91.98% <100.00%> (+0.94%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 81.42% <0.00%> (+4.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ea273...f49c990. Read the comment docs.

@hsuanxyz hsuanxyz marked this pull request as ready for review March 8, 2021 09:00
@hsuanxyz hsuanxyz requested a review from vthinkxie March 8, 2021 09:01
@vthinkxie vthinkxie merged commit c535f06 into NG-ZORRO:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants